Auto-rotation happens even when presenting controller returns 'shouldAutoRotate' as 'NO'

[jasperblues]

Using SDCAlertView as follows, the controller that presents the alert view returns shouldAutoRotate as 'NO', however SDCAlertView sill rotates.

Is there an easy way to turn this off?

Its not possible to use SDCAlertController, as the view is being presented as follows:

• Camera Scanning view
• A 'frosty' overlay on the camera view. Works like [self presentViewController] except it has a custom animation on presentation, and uses UIToolbar to give a real-time iOS blur on the camera feed.

(seems SDCAlertController doesn't like the above), but SDCAlertView is happy enough, except for the minor issue of unwanted auto-rotation.

Presenting Controller

The window has been given a root view controller, in this case a dedicated one, with its view having containers matching the diagram below.

• Encapsulates app-wide UI concerns, and provides an interface for these.
• Provides a container for application layout, and the appropriate to define custom animations for the presentation and dismissal of these views.
• Makes UIViewContainment calls (willMoveToParentController, etc) when presenting dismissing contained views.

The implementation of shouldAutoRotate in the custom root controller is:

- (BOOL)shouldAutorotate
{
    BOOL shouldAutoRotate = NO;
    if (_overlayController) {
        if ([_overlayController isKindOfClass:[UINavigationController class]]) {
            shouldAutoRotate = [((UINavigationController *) 
                _overlayController).topViewController shouldAutorotate];

        }
        else {
            shouldAutoRotate = [_overlayController shouldAutorotate];
        }
    }
    else {
        UIViewController *topController = _navigator.topViewController;
        shouldAutoRotate = [topController shouldAutorotate];
    }
    return shouldAutoRotate;
}

. . . the above autoRotate works as expected everywhere except for the SDCAlertView that is being presented as described. Adding a debug shows that:

• While the alert view is being presented, the first shouldAutoRotate returns the auto-rotation of _overlayController.topViewController, which is 'NO'. Yet auto-rotation still happens.

[sberrevoets]

Yeah, I see what the problem is. SDCAlertView is presented in its own window, and doesn't currently have any custom rotation behavior, which I think just means "always rotate".

Making the alert view controller have the same rotation behavior as the user window's current view controller wouldn't be too hard. The coordinator would have to figure out rotation behavior from the user window's view controller and apply it to the alert view controller as well.

I probably won't have time to look at this until next weekend, so if feel free to give it a shot if you're feeling adventurous. I can give you a few pointers if you want. Otherwise, I hope I can issue a fix next weekend.

[jasperblues]

I would love to have a shot at it, but:

• Currently getting an App ready for 1.0 submission to store.
• Doing support for www.typhoonframework.org

In terms of impact, the issue doesn't bother us too much, thought its worth mentioning hence this ticket.

[sberrevoets]

Sure, no problem! I'll get to it eventually, thanks for bringing it up.

[jasperblues]

👍 Thanks again for a super useful library.

[sberrevoets]

Sure, no problem! Glad you like it.

[sberrevoets]

I tried it myself, and I believe this is fixed now. Please let me know if you're still encountering issues!

[jasperblues]

Great! Verify from :head or from latest in CocoaPods mater repo?

[sberrevoets]

I haven't updated CocoaPods yet, so you'll want to pull the latest from here until CocoaPods is up to date as well.

[jasperblues]

OK pod 'SDCAlertView', :head it is then.

[jasperblues]

Verified here. 👍

[marcaudefroy]

Hello, soon a new pod version contains this fix?

[sberrevoets]

Yes, I'll look into updating the CocoaPods version to include this and a number of other fixes soon.