Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for SBG "Test" tab #31

Closed
davidroberson opened this issue Sep 17, 2016 · 5 comments
Closed

support for SBG "Test" tab #31

davidroberson opened this issue Sep 17, 2016 · 5 comments
Assignees
Labels

Comments

@davidroberson
Copy link

I test multiple revisions of a tool on CGC/SBG platform. Every time the revision is pushed the "Test" tab is blanked out and I have to re-input to test the command line expression.

Would be great if I could add the "Test" information via R script.

@tengfei
Copy link
Contributor

tengfei commented Sep 20, 2016

Interesting, I need to figure out wether it's generic public API problem are the R client's problem. thanks Dave!

@tengfei
Copy link
Contributor

tengfei commented Sep 20, 2016

I think it's more like a new feature on platform, if the public API doesn't support this feature, R client cannot easily do it. I will file a ticket for this, it's a very good suggestion.

@duxan
Copy link
Contributor

duxan commented Sep 20, 2016

I believe that test values are kept in "sbg:job" key of tool.json when viewed on platform (and also accessible through API). If that info is added to tool json in R and then uploaded as new revision - it should preserve the same test values. Haven't tested it though.

@tengfei
Copy link
Contributor

tengfei commented Sep 20, 2016

Thanks a lot @duxan I think this is the answer, it should work. my bad I forget this, because I did quick test and forget to "save" it before export to json, then wondering why it's not encoded in my cwl .....

@davidroberson could you please try something like this and push it.

rbx <- Tool(id = "runif",
            label = "Random number generator",
            hints = requirements(docker(pull = "tengfei/runif"), 
                                 cpu(1), mem(2000)),
            baseCommand = "runif.R",
            inputs = in.lst, ## or ins.df
            outputs = out.lst, 
            'sbg:job' = list(allocatedResources = list(mem = 9000, 
                                                       cpu = 1), 
                             inputs = list(
                                 min = 1, 
                                 max = 150
                             )))

At the same time, I may need to make it easier to allow user pass "job" directly.

@tengfei tengfei self-assigned this Dec 13, 2016
@tengfei
Copy link
Contributor

tengfei commented Dec 19, 2016

Add keep_test argument to task_add() so when you push a Tool object with no sbg:job info, you can still use keep_test = TRUE to keep previous test info.

@tengfei tengfei closed this as completed Dec 19, 2016
@nanxstats nanxstats added the cwl label Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants