Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to depend on new sbi 0.20.0 #50

Merged
merged 7 commits into from Feb 18, 2023
Merged

Refactor to depend on new sbi 0.20.0 #50

merged 7 commits into from Feb 18, 2023

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Oct 25, 2022 •
edited

refactor sbi run scripts to match the new API of sbi version >=0.20.0.

  • depend on newest sbi version 0.20.0 to support passing TransformedDistributions as prior
  • run all tests.

@janfb janfb changed the title Refactor for sbiv019 Refactor to depend on new sbi 0.20.0 Nov 8, 2022
@janfb
Copy link
Contributor Author

janfb commented Nov 8, 2022

ready for review @jan-matthis

jan-matthis
jan-matthis reviewed Nov 21, 2022
View reviewed changes
Copy link
Contributor

@jan-matthis jan-matthis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

A few small comments below

sbibm/algorithms/sbi/sl.py Show resolved Hide resolved
sbibm/algorithms/sbi/snle.py Outdated Show resolved Hide resolved
sbibm/algorithms/sbi/snle.py Outdated Show resolved Hide resolved
sbibm/algorithms/sbi/sl.py Show resolved Hide resolved
sbibm/algorithms/sbi/snle.py Outdated Show resolved Hide resolved
sbibm/algorithms/sbi/snre.py Outdated Show resolved Hide resolved
sbibm/algorithms/sbi/snre.py Outdated Show resolved Hide resolved
tests/algorithms/sbi/test_snle_posterior.py Show resolved Hide resolved
tests/algorithms/sbi/test_snpe_posterior.py Show resolved Hide resolved
tests/algorithms/sbi/test_snre_posterior.py Show resolved Hide resolved
@janfb
Copy link
Contributor Author

janfb commented Dec 2, 2022

Thanks for the feedback!

I remove a couple of test files and refactored them into one single sbi test file: test_sbi_run_methods.py

That tests now also inclused sl.

@janfb
Copy link
Contributor Author

janfb commented Dec 2, 2022 •
edited

I also changed the requirement to sbi>=0.20.0, as we will likely release a new version that incluces BNRE and SNRE_C soon.

Or do you prefer to fix the setup to one specific sbi version?

@jan-matthis jan-matthis merged commit 03db23e into sbi-benchmark:main Feb 18, 2023
@jan-matthis
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-matthis jan-matthis jan-matthis left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janfb @jan-matthis