Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding binder #554

Open
schmitts opened this issue Nov 22, 2021 · 1 comment
Open

Consider adding binder #554

schmitts opened this issue Nov 22, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers less-urgent This is beyond the current 2 week horizon

Comments

@schmitts
Copy link

Consider adding binder for trying out sbi easily. I've create one for my fork of sbi. I had to remove the environment.yml, because binder hat trouble creating the docker (ERROR: File "setup.py" or "setup.cfg" not found. Directory cannot be installed in editable mode: /home/jovyan).

E.g. open a tutorial notebook from https://mybinder.org/v2/gh/schmitts/sbi/HEAD.

@jan-matthis
Copy link
Contributor

jan-matthis commented Jan 10, 2022

Thanks for the suggestion! Adding binder and/or colab support would be great.

In principle, repo2docker (which binder uses) should support environment.yml, see https://github.com/jupyterhub/binder/blob/master/doc/config_files.rst#environmentyml---install-a-conda-environment.

From the error message you report, the following line in our environment.yml might be problematic: https://github.com/mackelab/sbi/blob/main/environment.yml#L31: It installs sbi in editable mode for local dev as described in our wiki here: https://www.mackelab.org/sbi/contribute/#development-environment. I think it would be best to find a workaround in which we can keep the default name for our environment file, and ideally still install in editable mode. Any help would be appreciated!

@jan-matthis jan-matthis added enhancement New feature or request good first issue Good for newcomers less-urgent This is beyond the current 2 week horizon labels Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers less-urgent This is beyond the current 2 week horizon
Projects
None yet
Development

No branches or pull requests

2 participants