Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor neural_nets model structure #991

Open
2 tasks
gmoss13 opened this issue Mar 13, 2024 · 1 comment
Open
2 tasks

Refactor neural_nets model structure #991

gmoss13 opened this issue Mar 13, 2024 · 1 comment
Labels
architecture Internal changes without API consequences density_estimators good first issue Good for newcomers hackathon

Comments

@gmoss13
Copy link
Contributor

gmoss13 commented Mar 13, 2024

After the new DensityEstimator interface is introduced, we have a confusing structure:

  • neural_nets.density_estimators should contain only one file for flows, containing all classes of flow-based density estimators
  • neural_nets.flow.py and neural_nets.mdn.py should be combined and the file should be explicitly named as a util file (containing only builder functions for flow-based density estimators. Potentially move this to utils.
@gmoss13 gmoss13 added enhancement New feature or request good first issue Good for newcomers API changes This impacts the public API of the project (e.g. inference class). hackathon density_estimators architecture Internal changes without API consequences and removed enhancement New feature or request API changes This impacts the public API of the project (e.g. inference class). labels Mar 13, 2024
@fariedabuzaid
Copy link

I can have a look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
architecture Internal changes without API consequences density_estimators good first issue Good for newcomers hackathon
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fariedabuzaid @gmoss13