Skip to content
This repository has been archived by the owner on Jul 24, 2023. It is now read-only.

Question: on the TODO item - "fix handling of integers" #70

Open
binurs opened this issue Jul 31, 2018 · 1 comment
Open

Question: on the TODO item - "fix handling of integers" #70

binurs opened this issue Jul 31, 2018 · 1 comment

Comments

@binurs
Copy link

binurs commented Jul 31, 2018

Hello,
I am planning to use the go-python package in one of my demo project.
However I am a bit curious on this TODO item - "fix handling of integers (I did a poor job at making sure everything was ok)"
Not sure how this is going to affect the project. Could you please give some more details on this TODO item? ie, Whats missing and what you would like to add?
Would like to contribute into this, if I can :)

@sbinet
Copy link
Owner

sbinet commented Aug 3, 2018

Hi,

Apologies for the belated answer.

IIRC, what I meant with that to-do note was that I wasn't completely sure what I did for integers would work consistently between 32b and 64b platforms.
I mapped both 'PyInt' and 'PyLong' to Go's 'int'.
On a 64b machine, that should work. Probably not so much on a 32b one.

In hindsight, I should have probably matched them to int32 and int64...
(Probably something to do when/if I migrate this project to the go-python organization)

@popeye8777 popeye8777 mentioned this issue Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants