Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with video trimmer working code. Working code stopped working #152

Closed
aditya-mahajan96 opened this issue Jan 2, 2022 · 7 comments · Fixed by #157
Closed

Issue with video trimmer working code. Working code stopped working #152

aditya-mahajan96 opened this issue Jan 2, 2022 · 7 comments · Fixed by #157
Labels
addressed The issue is addressed, will be closed soon if no further reply

Comments

@aditya-mahajan96
Copy link

aditya-mahajan96 commented Jan 2, 2022

My working code of video trimmer stopped working and showing error . It was working fine earlier. Below is the screenshot of what it appears now. It was working all fine earlier. @sbis04 @themadmrj @domliang @ArjanAswal

Screenshot 2022-01-01 at 10 31 42 PM

and here is the pubspec for videos i have

video_trimmer: ^1.0.0
ffmpeg_kit_flutter: ^4.5.0-LTS
video_player: ^2.2.10
video_editor: ^1.2.2

If i add
ffmpeg_kit_flutter:
git:
url: https://github.com/shilangyu/ffmpeg-kit
ref: development-flutter
path: prebuilt/bundle-flutter-lts/default

Then error comes. -
Because myproject depends on video_trimmer ^1.0.0 which depends on ffmpeg_kit_flutter 4.5.0-LTS, ffmpeg_kit_flutter from hosted is required.

and if version is downgraded then

then its showing error on save

 _trimmer.saveTrimmedVideo(
      startValue: _startValue,
      endValue: _endValue,
      onSave: 

Screenshot 2022-01-02 at 9 14 28 AM

@sbis04
Copy link
Owner

sbis04 commented Jan 2, 2022

@aditya-mahajan96 when is the error occurring exactly, during saving the trimmed video? Is the video trimmer preview getting generated (the thumbnails)?

@sbis04 sbis04 added waiting for user reply Waiting for user to reply bug Something isn't working as expected labels Jan 2, 2022
@aditya-mahajan96
Copy link
Author

aditya-mahajan96 commented Jan 2, 2022

During the saving the trimmed video method i am getting errror . Yes i am getting the thumbnails of video trimmer.
In this project i have firebase notifications too

@sbis04 sbis04 removed the waiting for user reply Waiting for user to reply label Jan 2, 2022
@sbis04
Copy link
Owner

sbis04 commented Jan 2, 2022

Okay, firebase notifications shouldn't cause any issues I believe.

I'll look into the issue and try to reproduce it, by today.

@akshayrupareliya0912
Copy link

Have you completed crop, trim using videoeditor package?

@iamjithinjohnson
Copy link

is this issue fixed?

@iamjithinjohnson
Copy link

i solved this issue with migrating package manually into our project.

@sbis04
Copy link
Owner

sbis04 commented Mar 3, 2022

Sorry for the late fix. Have updated the package to use the latest version of ffmpeg_kit_flutter (4.5.1-LTS), this should fix this issue.

@sbis04 sbis04 added addressed The issue is addressed, will be closed soon if no further reply and removed bug Something isn't working as expected labels Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addressed The issue is addressed, will be closed soon if no further reply
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants