Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-scrollable Timeline #187

Open
Weav3r opened this issue Dec 7, 2022 · 7 comments
Open

Non-scrollable Timeline #187

Weav3r opened this issue Dec 7, 2022 · 7 comments
Labels
addressed The issue is addressed, will be closed soon if no further reply waiting for user reply Waiting for user to reply

Comments

@Weav3r
Copy link

Weav3r commented Dec 7, 2022

Thank you for the time and effort in making and maintaining this great package.

Problem

As I understand the scrollable trim viewer is enabled when the video duration is greater than the maxVideoLength. However, I cannot get the timeline (with thumbnails) to scroll. Setting ViewerType.scrollable does nothing as well. Using debugPrint, I know the flag _isScrollableAllowed is set to true.

Minimal Reproducible Example

Used the official example in this repo.

trimmer

Other Info

video_trimmer: 2.0.1

Flutter doctor
[✓] Flutter (Channel stable, 3.3.9, on Linux 6.0.11-arch1-1, locale en_GB.UTF-8)
• Flutter version 3.3.9 on channel stable at /home/name/Android/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision b8f7f1f986 (2 weeks ago), 2022-11-23 06:43:51 +0900
• Engine revision 8f2221fbef
• Dart version 2.18.5
• DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
• Android SDK at /home/name/Android/Sdk
• Platform android-33, build-tools 33.0.0
• Java binary at: /home/name/android-studio/jre/bin/java
• Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
• All Android licenses accepted.

@tudosxxx
Copy link

tudosxxx commented Jan 6, 2023

mee too

@sbis04
Copy link
Owner

sbis04 commented Jan 8, 2023

Basically, the way it is implemented: you have to drag to the end and hold for 300 milliseconds for the scrolling to start. Let me know if you still can't scroll @Weav3r @tudosxxx

@sbis04 sbis04 added waiting for user reply Waiting for user to reply addressed The issue is addressed, will be closed soon if no further reply labels Jan 8, 2023
@tudosxxx
Copy link

tudosxxx commented Jan 9, 2023

This movement is not silky

@Weav3r
Copy link
Author

Weav3r commented Jan 16, 2023

@sbis04 Thanks for the response and sorry for the late reply. For some reason I can't get it to work when I drag with my fingers but I can get it to work when using a trackpad (or mouse) on my device screen which is mirrored on my PC. IDK maybe my big fingers cannot provide the precise input needed to trigger the scroll.
After asking a bunch of colleagues to try it out, none was able to get it working by dragging to the end and holding.

@Helocominc
Copy link

Doesn't scroll after 300ms. It just stuck at the edge of the screen. @sbis04

@JmyW
Copy link

JmyW commented Apr 12, 2023

me too. It stuck at the edge, not scroll.
Same on both Android and iOS.

@jpetro416
Copy link

jpetro416 commented May 10, 2023

Can confirm this does not fix the issue:

 TrimViewer(
     type: ViewerType.fixed,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addressed The issue is addressed, will be closed soon if no further reply waiting for user reply Waiting for user to reply
Projects
None yet
Development

No branches or pull requests

6 participants