Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking error in host.pp #22

Closed
aepgit opened this issue Oct 12, 2016 · 1 comment
Closed

Checking error in host.pp #22

aepgit opened this issue Oct 12, 2016 · 1 comment

Comments

@aepgit
Copy link

aepgit commented Oct 12, 2016

The line host.pp:21 has an error in the if check:
"if !is_domain_name($address) or !is_ip_address($address)"

The "or" should be "and", since now it only passes if the address is both a domain_name AND and ip_address because of the double-negative.
With an "and" it would check if it's neither a domain_name or an ip_address.

I have the fix ready if you grant me rights for creating a branch/pull request.

@jonhattan
Copy link
Member

Si I took my time to merge it 😄. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants