License issues

[davidhedlund]

You are right, the LICENSE file is enough for MIT License.

[sblask]

I didn't bother reading through this wall of text, just two comments: there is a LICENSE file which I won't duplicate and I don't see how license headers make any difference. If people care about the license, it's there. If they don't, they will ignore it whether it's in a separate file or in the header.

[davidhedlund]

MIT License

Copyright (c) <year> <copyright holders>

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

So can you please add this to your .js files (as required by the license):

Copyright (c) 2017 Sebastian Blask

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

[davidhedlund]

Please read mozilla/addons#4734 and vote on the comment to help us on the Free Software Directory speed up the license approval process.

[davidhedlund]

I added the license notices for you:

master...davidhedlund:patch-1
master...davidhedlund:patch-2
master...davidhedlund:patch-3
master...davidhedlund:patch-4
master...davidhedlund:patch-5
master...davidhedlund:patch-6

[sblask]

Please reference a document that says that I as the AUTHOR HAVE to add such a header to all the source files. Because the license doesn't. And even if, I would understand permission notice as the second paragraph, not the fourth (the warranty section).