Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versioning mechanism broken #7

Open
joelb123 opened this issue Oct 10, 2022 · 0 comments
Open

versioning mechanism broken #7

joelb123 opened this issue Oct 10, 2022 · 0 comments

Comments

@joelb123
Copy link

The versioning mechanism in setup.py sets version to "Undefined", then does an exec() from init.py to get the version number from inside the file. Presumably this was done to have the version number appear in only one place, and it must have worked for PYPI the last time the package was distributed. Unfortunately, it breaks the rules for pip installs direct from the repo, as the exec never gets done. This really matters for those of us working from a PR like the one to do v2 search.

I believe the recommended way to do it is to put the static version in the package declaration and use importlib inside the module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant