Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L3 709- Compartments don't have spatial dimension! #25

Closed
luciansmith opened this issue Jun 10, 2010 · 3 comments
Closed

L3 709- Compartments don't have spatial dimension! #25

luciansmith opened this issue Jun 10, 2010 · 3 comments
Assignees
Labels
auto-migrated sourceforge Test data/results issue Work concerning test case data or results

Comments

@luciansmith
Copy link
Member

Hello,

I've run into another problem with the L3 models and the sbml test suite. There are a couple of models, like 709, 710 ... that I can pass for L2V4 but not for L3 ... when I was debugging it it would seem that no spatial dimension is specified on the compartment

In L2V4: <compartment id="C" name="C" size="0.5" units="volume"/>
means spatialDimensions = 3

in L3V1: <compartment id="C" name="C" size="0.5" units="volume" constant="true"/>
means spatialDimensions = not defined!

In any case ... that changes this result for me! ... I believe there is a whole round of those models around ... (or at least I hope so otherwise something else is wrong)

Cheers
Frank

Reported by: fbergmann

@luciansmith
Copy link
Member Author

This is indeed a bug. A translation from l2 should set spatialDimensions to 3 if there are not declared on the l2 model - since this is the default value.

The models are now fixed in svn.

Original comment by: sarahkeating

@luciansmith
Copy link
Member Author

thanks that solved the issue ... now we pass the same number of tests for L3V1 as for L2V4 ...

Cheers
Frank

Original comment by: fbergmann

@luciansmith
Copy link
Member Author

  • status: open --> closed

Original comment by: fbergmann

@luciansmith luciansmith added Test data/results issue Work concerning test case data or results sourceforge auto-migrated labels Aug 9, 2016
@luciansmith luciansmith self-assigned this Aug 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-migrated sourceforge Test data/results issue Work concerning test case data or results
Projects
None yet
Development

No branches or pull requests

1 participant