Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbopkg incorrectly returns '0' when build fails #85

Closed
andy5995 opened this issue Jan 5, 2023 · 2 comments
Closed

sbopkg incorrectly returns '0' when build fails #85

andy5995 opened this issue Jan 5, 2023 · 2 comments

Comments

@andy5995
Copy link
Contributor

andy5995 commented Jan 5, 2023

To reproduce:

sbopkg -B -b PDCurses -e stop

0 is returned. (Build fails because it can't find 'Intrinsic.h').

@willysr
Copy link
Member

willysr commented Jan 5, 2023

i think that is the intended behaviour, since the process ended by writing the result to log (which is a success), although the build failed

@andy5995
Copy link
Contributor Author

andy5995 commented Jan 5, 2023

Ok. My thinking was that it would be better if non-zero is returned, so when sbopkg is run from a script or a CI, they would also exit with non-zero when a non-interactive option (e.g. -B) was given.

If you're sure you want to keep the behavior as-is, feel free to close the ticket. Thanks for the response @willysr

@willysr willysr closed this as completed Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants