Guard list against invalid string defaults (#607)

* Guard list against invalid string defaults * Uses Math.max based on review feedback
SBoudrias · Nov 2, 2017 · ce4e858 · ce4e858
1 parent 651a569
commit ce4e858
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/lib/prompts/list.js b/lib/prompts/list.js
@@ -38,7 +38,8 @@ function Prompt() {
   if (_.isNumber(def) && def >= 0 && def < this.opt.choices.realLength) {
     this.selected = def;
   } else if (!_.isNumber(def) && def != null) {
-    this.selected = this.opt.choices.pluck('value').indexOf(def);
+    let index = this.opt.choices.pluck('value').indexOf(def);
+    this.selected = Math.max(index, 0);
   }
 
   // Make sure no default is set (so it won't be printed)

diff --git a/test/specs/prompts/list.js b/test/specs/prompts/list.js
@@ -148,6 +148,18 @@ describe('`list` prompt', function () {
     this.rl.emit('line');
   });
 
+  it('shouldn\'t allow an invalid string default to change position', function (done) {
+    this.fixture.default = 'babar';
+    var list = new List(this.fixture, this.rl);
+
+    list.run().then(function (answer) {
+      expect(answer).to.equal('foo');
+      done();
+    });
+
+    this.rl.emit('line');
+  });
+
   it('shouldn\'t allow an invalid index as default', function (done) {
     this.fixture.default = 4;
     var list = new List(this.fixture, this.rl);