Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExternalOfficeManager can't convert streams #116

Closed
buxxi opened this issue Nov 26, 2018 · 1 comment
Closed

ExternalOfficeManager can't convert streams #116

buxxi opened this issue Nov 26, 2018 · 1 comment

Comments

@buxxi
Copy link

buxxi commented Nov 26, 2018

When using the ExternalOfficeManager it throws an exception when trying to convert from an InputStream to an OutputStream.

An office manager must implements the TemporaryFileMaker interface in order to be able to convert to OutputStream.

I can't really see why the ExternalOfficeManager couldn't implement that interface too as AbstractOfficeManagerPool does, since it is only doing local connections.

Maybe there could be another method on the ExternalOfficeManagerBuilder for providing what TemporaryFileMaker to use instead of relying on casting to another interface?

new ExternalOfficeManagerBuilder().setTemporaryFileMaker(customImplementation).build();

I've wrapped the ExternalOfficeManager and implemented TemporaryFileMaker on it and it seems to be working fine as a workaround.

@sbraconnier
Copy link
Member

The next release will have a ExternalOfficeManager similar to the LocalOfficeManager. Streams will be supported. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants