-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open Office template types are missing from the documentformat.json #24
Comments
Thank you so much for your feedback. Since you seem to have spent some time to search for the filter that represents a template as source document, could you please hint me on what should be added to this file. Note: About the supported formats (conversions), you don't need to "extend" this project. You can specify a custom document format registry. Here's an (untested) example: JsonDocumentFormatRegistry customRegistry = JsonDocumentFormatRegistry.create(some file or input stream containing the document formats you want to support);
final File inputFile = ...
final File outputFile = ...
LocalConverter
.builder()
.formatRegistry(customRegistry)
.build()
.convert(inputFile)
.to(outputFile)
.execute(); |
I've merged your PR after changing it a bit to use the proper storage template filter types. I also added the ability to disable OpenGL for LibreOffice (don't know why but once in a while, when converting a template... boom... LO crashes. Apache Open Office does not). Let me know if everything still works fine on your side, so that this issue could be closed. |
Oh, that is interesting. So you get crashes when converting templates too?
We experience this problem as well and I do not know the reason at all yet.
I will check if your solution fixes our problem as well. Thx!
…On 22:28, Tue, Sep 12, 2017 Simon Braconnier ***@***.***> wrote:
I've merged your PR after changing it a bit to use the proper storage
template filter types.
I also added the ability to disable OpenGL for LibreOffice (don't know why
but once in a while, when converting a template... boom... LO crashes.
Apache Open Office does not).
Let me know if everything still works fine on your side, so that this
issue could be closed.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AC97q9uu1wILlInO3gXZpZ7n8I8v2X9Iks5shulRgaJpZM4PQ6-7>
.
|
OpenGL was not properly disabled prior to this commit I made this morning, so you may have to update your fork with my latest changes. Disabling OpenGL solved the problems I had with ott files. But I still have some troubles with otp files. Not sure if you just need to convert ott files. Note that changing the OpenGL setting requires a LibreOffice restart (which JODConverter takes care of). Another thing you could try is to set the templateProfileDir to a path of a (copy of a) user directory you would have configured with the best settings for your conversions. If you disable OpenGL this way (the option is in the Tools / Options / LibreOffice -> View menu item), it won't require a LibreOffice restart. Here on my Windows, after settings LibreOffice to suit my needs, I copied the directory It works without any crash, even for otp files! |
I am thinking about using template user settings anyway, since we have problems with using the user settings that come with a fresh libreoffice portable on different machines. So your hint might give us a much better experience. |
Since the conversion can also start from the template types of open office, the types should also be included. I added at least the OTT in my local version of your code.
The text was updated successfully, but these errors were encountered: