Add docker file #254
Merged
Add docker file #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
force-pushed
the
docker
branch
12 times, most recently
from
9f8045d
to
f0a7726
Compare
sbrunner
force-pushed
the
docker
branch
3 times, most recently
from
0a0ea40
to
2e7484e
Compare
| COPY requirements.txt /src/ | ||
| COPY README.rst /src/ | ||
| COPY CHANGES.rst /src/ | ||
| COPY tilecloud_chain /src/tilecloud_chain |
There was a problem hiding this comment.
You should do that in less lines to avoid too many layers:
COPY setup.py requirements.txt README.rst CHANGES.rst /src/
COPY tilecloud_chain /src/tilecloud_chain
I usually tend to have the files following the directory structure they'll have in the destination and do a single COPY . /src/ using a .dockerignore file to avoid copying the Dockerfile and other unwanted files.
sbrunner
force-pushed
the
docker
branch
2 times, most recently
from
cb2afe3
to
667c2e4
Compare
| run_file.write('os.umask(0o{})\n'.format(os.environ['UMASK'])) | ||
| run_file.write('subprocess.check_call({})\n'.format(repr(sys.argv[1:]))) | ||
|
|
||
| run_file_name = "/tmp/run" |
|
Small detail, appart from that all good. Please merge when fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New docker image that contains a tilecloud chain ready to generate tiles.