Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Signup form translateable #69

Open
kleinicke opened this issue Sep 4, 2022 · 1 comment
Open

Make Signup form translateable #69

kleinicke opened this issue Sep 4, 2022 · 1 comment
Assignees

Comments

@kleinicke
Copy link
Member

Currently the Signup form is defined in the folder src/signup-form/de/. For other websites, the de can be exchanged with for example a us, at or it.

@kleinicke
Copy link
Member Author

@janosh
The new signupform can be translated and is shown for each of the languages.
The submit part of the implementation is still missing.

Current issues, are when the signup form is loaded directly without being redirected from another URL, the site won't load.
The reason is, that the microcopy signup store is not filled yet.
This leads to an undefined country entry:

import { microcopy } from '$lib/stores'
import { get } from 'svelte/store'
var country = get(microcopy).country
console.log('country', country)

Which leads to error messages when the form is loaded. We need to wait until the signup store is filled until, we can access the country and continue importing the yml files for the form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant