Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(It is not a test) tests reported #53

Closed
francisdb opened this issue Jul 11, 2014 · 8 comments
Closed

(It is not a test) tests reported #53

francisdb opened this issue Jul 11, 2014 · 8 comments

Comments

@francisdb
Copy link

related to the test reporting that was implemented for #48

I see a lot of these reported in Jenkins where my specs2 tests are reported by the junit reporter

<testcase classname="xx.xxx.FooSpec" name="(It is not a test)" time="-0.001"></testcase>

So the reporting is not skipping files that are not JUnit test files

@benmccann
Copy link
Contributor

@francisdb should this be closed now given that you said it was working for you now on #48?

@francisdb
Copy link
Author

@benmccann Maybe I did not make this clear enough, sorry about that. Test reports are working but I see the above issue in my report files and on jenkins. So the report is generated but contains these annoying dummy not a test lines causing the test count to be wrong...

@benmccann
Copy link
Contributor

Ok, thanks. I misunderstood then. Thanks for clarifying

@francisdb
Copy link
Author

Hmm, I think that this is a specs2 issue as I have this error even without running JUnit tests.
see the linked specs2 issue

@dcsobral
Copy link

I don't understand why this is closed. The linked Specs2 issue basically says "disable the Junit Interface, because that is broken". It is not Specs2 generating the files with "it is not a test", it's the JUnitXmlReportPlugin -- which is easily verified by disabling it.

Now, while that works for projects that ONLY contain Specs2 tests, or, I assume, projects that contain JUnit tests (I have no idea how ScalaTest fares here), projects containing both need to resort to awkward work-arounds so tha tthe JUnitXmlReportPlugin won't overwrite the files generated by Specs2.

@francisdb
Copy link
Author

Hmm, I was a bit to fast in my conclusion and we still have issues. I personally don't see who's fault this is... Is this JUnitXmlReportPlugin not supposed to be a universal solution for generating reports for any test framework?

@francisdb francisdb reopened this Oct 10, 2014
@dcsobral
Copy link

I'm all for JUnitXmlReportPlugin being an universal solution -- in which case it shouldn't tag Specs2 tests as "It is not a test".

@francisdb
Copy link
Author

Closing this again as the issue is actually in specs2 not setting up the events correctly

etorreborre/specs2#283 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants