Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssemblyUtils.sourceOfFileForMerge no longer public #435

Open
kshakir opened this issue Jun 13, 2021 · 4 comments
Open

AssemblyUtils.sourceOfFileForMerge no longer public #435

kshakir opened this issue Jun 13, 2021 · 4 comments

Comments

@kshakir
Copy link

kshakir commented Jun 13, 2021

In the 1.0.0 README.md it says:

Custom MergeStrategys can find out where a particular file comes
from using the sourceOfFileForMerge method on sbtassembly.AssemblyUtils

But as of #433 sbtassembly.AssemblyUtils is no longer public leading to:

object AssemblyUtils in package sbtassembly cannot be accessed in package sbtassembly
  • Is AssemblyUtils meant to be private?
  • Is there a replacement for sourceOfFileForMerge?
  • Should the README be updated?
@eed3si9n
Copy link
Member

eed3si9n commented Jun 13, 2021

Yea. Sorry about that. I did mean to make it private, but didn't think it would have negative impact. We can expose the function somehow.

@koertkuipers
Copy link

i ran into this too. we use sourceOfFileForMerge in a custom MergeStrategy as well. maybe have MergeStrategy.sourceOfFileForMerge?

@chipsenkbeil
Copy link

Also encountered this and ended up making a copy of it within my project.

@cocreature
Copy link

Is there a variant of sourceOfFileForMerge that still works? It looks like the code has been completely deleted now.

By usecase is that I have a multiproject build and I'm trying to figure out which project produced a class file but nothing in Project dependency seems useful for that. The name just points to the root project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants