Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full URLs are not supported #1

Closed
vpetro opened this issue Nov 4, 2016 · 3 comments
Closed

Full URLs are not supported #1

vpetro opened this issue Nov 4, 2016 · 3 comments

Comments

@vpetro
Copy link
Contributor

vpetro commented Nov 4, 2016

Giter8 supports the use of full URLs to load a template. However, the sbt new command does not provide the same support.

Example:

~  λ sbt new https://github.com/eed3si9n/hello.g8
[info] Loading global plugins from /Users/petrov/.sbt/0.13/plugins
[info] Updating {file:/Users/petrov/.sbt/0.13/plugins/}global-plugins...
[info] Resolving org.fusesource.jansi#jansi;1.4 ...
[info] Done updating.
[info] Compiling 1 Scala source to /Users/petrov/.sbt/0.13/plugins/target/scala-2.10/sbt-0.13/classes...
[info] Set current project to petrov (in build file:/Users/petrov/)
Template not found for: https://github.com/eed3si9n/hello.g8
~  λ g8 https://github.com/eed3si9n/hello.g8
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
name [hello]:
@eed3si9n
Copy link
Member

eed3si9n commented Nov 5, 2016

Fixed in #2

@eed3si9n eed3si9n closed this as completed Nov 5, 2016
@m-yamaguchi
Copy link

This issue is not yet fixed.
Pattern match in Giter8TemplateResolver is incorrect.
args.headOption returns an Option[String].
So, the following change is needed.

case GitUrl(uri) --> case Some(GitUrl(uri))

@dwijnand
Copy link
Member

dwijnand commented Nov 7, 2016

You're right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants