Add license header. #131
Merged
Add license header. #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah that's true.
Yes, it's fine - same as using any class of the JDK :) |
|
Thanks! |
|
Do you want to add it to the extras too? (it absolutely is apache 2 as well) |
|
Oh, I am late. I think I would try |
|
Yeah, just send another one :) thanks so much!
…On Sep 11, 2017 12:53, "Jimin Hsieh" ***@***.***> wrote:
Oh, I am late. I think I would try extras locally. If there is no other
issue, I send another PR?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#131 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAHYk8wsXPDoMr3g_P0SlLBH8RiFle23ks5shREfgaJpZM4PR3xU>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only added license header in
pluginproject withoutextrasproject becauseextrasdidn't specific license inbuild.sbt. I think we could move sbt-key -licensestocommonSettingsto let all projects with Apache-2.0. Since JMH is used GPLv2 with Classpath exception as OpenJDK, I think it should be fine.