Make classDirectory+dependencyClasspath configurable

[magro]

As mentioned in #63 (comment) one can hack around the hardcoded config that is used for classDirectory and dependencyClasspath (both are taken from the Compile config).

This change allows the user to set

classDirectory in Jmh := (classDirectory in Test).value
dependencyClasspath in Jmh := (dependencyClasspath in Test).value

so that jmh will use the appropriate values.

Not sure if this change provides enough value to be merged, at least it seems to be cleaner when having benchmark code in the Test config.

[ktoso]

I think that's a great PR, thanks for prepping it :)

[magro]

Great you like it! In #63 (comment) I actually left out some details regarding module dependencies (mixed "compile->test" + "test->test") that can be solved with this PR as I just realized :-)

[ktoso]

Thanks :)

I guess we should document now "if you need test dependencies"... would you be able to make your comment into a snippet in the readme?

[magro]

To me it still seems to be a hack and would need further adjustments to be
considered a solution, although I'm not sure what this would be in detail
:-) If you think it's ok as it is I can send a PR for the readme.

Konrad Malawski notifications@github.com schrieb am Di., 5. Juli 2016,
18:39:

Thanks :)

I guess we should document now "if you need test dependencies"... would
you be able to make your comment into a snippet in the readme?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#73 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AAD7HWAoXbTGGMHJQp0iE6FJGofpBn9_ks5qSojGgaJpZM4JFSwW
.

[ktoso]

Well, it's a step forward.

The reason it's in this main scope was basically because I hoped it would be easier to setup package tasks, which hasn't happened yet though

[richdougherty]

To get jmh:run to trigger a build I think you also need to add something like:

generateJmhSourcesAndResources in Jmh := ((generateJmhSourcesAndResources in Jmh) dependsOn(compile in Test)).value,