Skip to content

Commit

Permalink
Fix Windows msi installer PATH entry
Browse files Browse the repository at this point in the history
During sbt installation on Windows7 x64 with the msi, SBT_HOME, [INSTALLDIR], was set to `C:\Program Files (x86)\sbt\`, PATH was then updated with `C:\Program Files (x86)\sbt\\bin` so sbt could not be run from the command line due to the double back slash.

I could not run windows:package-msi to test my change, but using SuperOrca to change the msi PATH from `[~];[INSTALLDIR]\bin` to `[~];[INSTALLDIR]bin` and reinstalling sbt with the updated msi fixed the problem.

Running `windows:package-msi` errored with:
`[error] Not a valid key: package-msi (similar: package-site, package-bin, package-src)`
  • Loading branch information
interestincode committed Feb 14, 2014
1 parent 332787c commit aea1a47
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ object WixHelper {
val homeEnvVar = archetypes.JavaAppBatScript.makeEnvFriendlyName(name) +"_HOME"
val pathAddition =
if(dir.isEmpty) "%"+homeEnvVar+"%"
else "[INSTALLDIR]\\"+dir.replaceAll("\\/", "\\\\")
else "[INSTALLDIR]"+dir.replaceAll("\\/", "\\\\")
val id = cleanStringForId(dir).takeRight(65) + "PathC"
val guid = makeGUID
val xml =
Expand Down

0 comments on commit aea1a47

Please sign in to comment.