Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinuxPlugin: Config files are not set as config if have execute permission #1382

Closed
SalehDehqanpour opened this issue Dec 13, 2020 · 1 comment

Comments

@SalehDehqanpour
Copy link
Contributor

Expected behaviour

sbt debian:packageBin should set meta "config" flag (in linuxPackageMappings) for all config files (i.e. those under "conf" directory) so they will be put in debian conffiles (and for other usages of the flag). Obviously the permission of files should not affect this.

Actual behaviour

sbt debian:packageBin will not put files under "conf" directory if they have execute permission set. So the conffiles does not contain them and this will cause problem when using that deb for upgrade purposes. This problem specially will occur when using Windows platform to generate packages (by using JDeb for example) because Windows has no notion of that permissions and by default all files are "777".

The issue is because of this line. The files are categorized sequentially in "executable", "doc", ... . But the order is wrong. Any file under conf should not be executable.

Information

  • What sbt-native-packager are you using
    v1.8.0-RC14

  • What sbt version

  • What is your build system (e.g. Ubuntu, MacOS, Windows, Debian )
    Ubuntu and Windows (but issue is generic)

  • What package are you building (e.g. docker, rpm, ...)
    debian

  • What version has your build tool (find out with e.g. rpm --version)
    dpkg 1.17.5

  • What is your target system (e.g. Ubuntu 16.04, CentOS 7)
    Debian

@muuki88
Copy link
Contributor

muuki88 commented Dec 14, 2020

Thanks for the detailed issue and the PR ❤️ in #1383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants