Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to scala-xml 2 #1513

Closed
kryptt opened this issue Jul 27, 2022 · 6 comments · Fixed by #1514
Closed

Update to scala-xml 2 #1513

kryptt opened this issue Jul 27, 2022 · 6 comments · Fixed by #1514
Labels
feature request project General project issues

Comments

@kryptt
Copy link

kryptt commented Jul 27, 2022

More and more sbt plugins are moving to scala-xml 2, for example now I've been blocked from upgrading sbt-scoverage

See:
scoverage/scalac-scoverage-plugin#488
scoverage/sbt-scoverage#439
fthomas/refined#1098

@muuki88 muuki88 added project General project issues feature request labels Jul 31, 2022
@muuki88
Copy link
Contributor

muuki88 commented Jul 31, 2022

IIRC there was already an attempt made, but rolled back due to other incompatibilities.

@SethTisue
Copy link
Member

SethTisue commented Aug 3, 2022

I suggest you bite this bullet. It's nearly unheard of for the upgrade to actually cause a problem. The major version number bump frightens people, but the removed things were already deprecated and rarely used anyway.

@SethTisue
Copy link
Member

I don't see any previous upgrade attempt other than #1454

@armanbilge
Copy link
Contributor

Well I did the obvious thing and CI seems fine. #1514

@muuki88
Copy link
Contributor

muuki88 commented Aug 5, 2022

Thanks for all the input 😄 I'll merged the PR and will release next week.

@mkurz
Copy link
Member

mkurz commented Oct 14, 2022

IMHO next time such an major version bump like from scala-xml 1 to 2 should not be done in a patch release... People start a lot to open issues and ask in chats about the whole scala-xml upgrade mess.
Such changes should be coordinated better next time... Like someone should open pull requests at once in all major plugins and libraries and they all should release new versions within a couple of days....
Also, like I am asking myself, why did get scala-xml bumped to 2 but not scala-parser-combinators? It's just random. We will have the same mess soon with that library...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request project General project issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants