Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't override packageName in UniversalPlugin #902

Closed
muuki88 opened this issue Oct 31, 2016 · 3 comments
Closed

Don't override packageName in UniversalPlugin #902

muuki88 opened this issue Oct 31, 2016 · 3 comments
Labels
universal Zip, tar.gz, tgz and bash issues
Projects
Universal

Comments

@muuki88
Copy link
Contributor

muuki88 commented Oct 31, 2016

Remove this line
@muuki88 muuki88 added the universal Zip, tar.gz, tgz and bash issues label Oct 31, 2016
@nafg
Copy link

nafg commented Feb 3, 2017

You should use links based on a commit or tag, not a branch. I don't think the link refers to the line you intended anymore.

@muuki88
Copy link
Contributor Author

muuki88 commented Feb 3, 2017

Damn, you are right. I messed this one up 😩
Thanks for the hint

@muuki88
Copy link
Contributor Author

muuki88 commented Feb 4, 2017

I actually meant this line.

I'm not happy with past-me. He provided not enough information why this is relevant.

@muuki88 muuki88 closed this as completed Feb 4, 2017
@muuki88 muuki88 moved this from Bugs to Done in Universal Feb 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
universal Zip, tar.gz, tgz and bash issues
Projects
Universal
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nafg @muuki88