Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sbt.internal.util.Terminal.proxyInputStream does not override available #6964

Closed
steinybot opened this issue Jul 10, 2022 · 1 comment · Fixed by #6965
Closed

sbt.internal.util.Terminal.proxyInputStream does not override available #6964

steinybot opened this issue Jul 10, 2022 · 1 comment · Fixed by #6965
Labels
Milestone

Comments

@steinybot
Copy link
Contributor

steinybot commented Jul 10, 2022

steps

  1. Add site-sbt to a project.
  2. Run previewAuto.
  3. Press any key.

Reproduction here: https://github.com/steinybot/bug-reports/tree/sbt/terminal-is-available

problem

It does not stop.

expectation

It should stop.

notes

sbt/sbt-site#168

unfiltered.util.RunnableServer has a busy loop polling for System.in.available() to be > 0 but it never is. This is because sbt.internal.util.Terminal.proxyInputStream does not override available but it should.

@eed3si9n
Copy link
Member

Thanks for the report!
Here's my PR for this - #6965

@eed3si9n eed3si9n added this to the 1.7.0 milestone Jul 10, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants