Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide nicer implementation of publishLocal / skip for 2.0.x series #7170

Open
mdedetrich opened this issue Mar 4, 2023 · 5 comments
Open
Assignees

Comments

@mdedetrich
Copy link
Contributor

mdedetrich commented Mar 4, 2023

As noted by #7165 (comment), there is a nicer implementation possible for the solution in that PR however it wasn't possible to cleanly implement due to an already existing deprecated function (see

@deprecated("Use variant without delivery key", "1.1.1")
def publishTask(
config: TaskKey[PublishConfiguration],
deliverKey: TaskKey[_],
): Initialize[Task[Unit]] =
publishTask(config)
).

Since its possible to remove that deprecated function in the 2.0.x series, once #7165 is merged into the 2.0.x branch a nicer implementation can be made

@mdedetrich
Copy link
Contributor Author

mdedetrich commented Mar 4, 2023

If you want just assign this to me (just ping me when that PR gets merged into 2.0.x)

@SethTisue
Copy link
Member

just ping me when that PR gets merged into 2.0.x

@eed3si9n that's not how it works in this repo is it?

@eed3si9n
Copy link
Member

eed3si9n commented Mar 4, 2023

develop branch is intended to be sbt 2.x so all we need to do is git merge. (I'm doing that for 2.x to make it easier to maintain 3 branches)

@mdedetrich
Copy link
Contributor Author

mdedetrich commented May 5, 2023

@eed3si9n I wanted to work on this however I noticed from #6746 that it appears you are working on your own local eed3si9n:wip/sbt-2.x branch rather than a sbt-2.x branch that sits in https://github.com/sbt.

Should I just wait until there is an equivalent 2.0.x branch in sbt upstream or should I make a pr against develop?

@eed3si9n
Copy link
Member

eed3si9n commented May 5, 2023

I have #6746 as pull request open, which I think needs to be reviewed by @adpi2 and others?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants