Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JLine version (3.19.0) is outdated #7498

Closed
SethTisue opened this issue Feb 15, 2024 · 5 comments
Closed

JLine version (3.19.0) is outdated #7498

SethTisue opened this issue Feb 15, 2024 · 5 comments
Labels
area/shell sbt shell and slash syntax related issues Bug

Comments

@SethTisue
Copy link
Member

sbt is still on JLine 3.19.0, which is quite old — it's from 2021. The JLine folks have fixed a ton of bugs since then. Current version is 3.24.1.

At minimum, it would be good for sbt 2.x to upgrade. We could also look at whether a backport to 1.x would be feasible.

@SethTisue SethTisue added Bug area/shell sbt shell and slash syntax related issues labels Feb 15, 2024
@SethTisue
Copy link
Member Author

SethTisue commented Feb 15, 2024

I fooled with this for an about an hour locally, but to get on 3.24.1, a bunch of changes to sbt.internal.util.JLine3 will be needed, and then I'm not sure how much more rabbit hole lies beyond that

@eed3si9n
Copy link
Member

Are they supposed to be backward compatible? In other words, if we injected the latest JLine 3.24.1 to classpath, would Scala 2.x REPL and Scala 3.x REPL continue to work?

@hamzaremmal
Copy link

hamzaremmal commented Feb 20, 2024

Are they supposed to be backward compatible? In other words, if we injected the latest JLine 3.24.1 to classpath, would Scala 2.x REPL and Scala 3.x REPL continue to work?

It doesn't look like this is the case for earlier versions of JLine3 (jline/jline3#189). Also, Scala 3 might be moving to JLine 3.25.1 (See scala/scala3#19744)

@eed3si9n
Copy link
Member

I also realized that we've already bumped JLine for sbt 1.10.x, and 1.10.0-M1 has been out for a while - https://repo1.maven.org/maven2/org/scala-sbt/sbt/1.10.0-M1/ and REPL seem to work fine for both Scala 2.13 and 3.

@SethTisue
Copy link
Member Author

I also realized that we've already bumped JLine for sbt 1.10.x, and 1.10.0-M1 has been out for a while

Oh, right you are. I mistakenly looked at the 1.x branch but did not look at the 1.10.x branch.

@SethTisue SethTisue closed this as not planned Won't fix, can't repro, duplicate, stale Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/shell sbt shell and slash syntax related issues Bug
Projects
None yet
Development

No branches or pull requests

3 participants