Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this names context-dependent #578

Open
jvican opened this issue Aug 16, 2018 · 2 comments
Open

Make this names context-dependent #578

jvican opened this issue Aug 16, 2018 · 2 comments

Comments

@jvican
Copy link
Member

jvican commented Aug 16, 2018

It occurred to me that because of the name heuristics, this can be a common source of conservative recompilation when changes in the source code happens. We fixed a similar issue with constructors in #288, and the same rationale applies here. I'm optimistic that, just like that change, this improvement can reduce unnecessary compilations and increase the efficiency of the recompilations.

@jvican
Copy link
Member Author

jvican commented Aug 16, 2018

Another common name is package, which we may just want to outright remove.

@jvican
Copy link
Member Author

jvican commented Aug 31, 2018

Like this, synthesized defs like the ones generated by default arguments (and maybe delayed init?) should also be prepended with the class name they are owned by to minimize recompilations. Currently: <init>$default$1, should be: foo;MyBar;<init>$default$1 just as in the PR in
#288 (/cc @smarter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants