RNAdMobRewardedVideoAdModule is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener #316

Buwaneka-Sumanasekara · 2018-05-30T09:25:15Z

../node_modules/react-native-admob/android/src/main/java/com/sbugert/rnadmob/RNAdMobRewardedVideoAdModule.java:25: error: RNAdMobRewardedVideoAdModule is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener
public class RNAdMobRewardedVideoAdModule extends ReactContextBaseJavaModule implements RewardedVideoAdListener {
^

ray-shawn · 2018-05-30T10:35:56Z

+1

koenpunt · 2018-05-30T22:09:10Z

This has been fixed already in #273 . Are you using the latest version of this library?

ray-shawn · 2018-05-31T01:21:36Z

I am using 1.3.2 @koenpunt , actually we do not wanna update version due to certain reason, how to handle this issue.

Oh I see.
// @OverRide Deprecated
public void onRewardedVideoCompleted() {
sendEvent(EVENT_VIDEO_COMPLETED, null);
}

wbrickner · 2018-12-18T12:49:24Z

I'm encountering this issue, installing directly from npm, following the installation instructions exactly.
What can I do to fix this?

Here are my logs:
$ react-native run-android

> Task :react-native-admob:compileDebugJavaWithJavac FAILED
/home/will/Documents/ReactNative/VideoToolkit/New/GIFit/node_modules/react-native-admob/android/src/main/java/com/sbugert/rnadmob/RNAdMobRewardedVideoAdModule.java:20: error: RNAdMobRewardedVideoAdModule is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener
public class RNAdMobRewardedVideoAdModule extends ReactContextBaseJavaModule implements RewardedVideoAdListener {
       ^
1 error


FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-admob:compileDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

I should mention:

Ubuntu 18.10
react-native-cli: 2.0.1
react-native: 0.57.8

Thank you for all the hard work you've done, I really appreciate it <3.

raikk · 2018-12-28T17:28:27Z

@wbrickner same issue here! have you fixed it?? Anyone please help

zxxza11 · 2018-12-29T17:03:35Z

same problem

Batuhan-Akkaya · 2019-01-05T15:35:48Z

same problem

amnan181 · 2019-01-14T07:37:27Z

same problem

Anandks1993 · 2019-01-15T09:16:02Z

same problem

SimonHudec · 2019-02-02T15:24:22Z

+1

sonicsmith · 2019-02-18T07:43:01Z

I'm having the same issue.
RewardedVideoAdModule is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener
react-native v0.58.4, react-native-admob v1.3.2

jdgalani · 2019-02-19T04:30:37Z

+1
exact same problem

ghost · 2019-02-25T13:04:09Z

+1

breakerof · 2019-03-01T11:39:09Z

+1

kinjal111 · 2019-03-02T06:32:04Z

Hello , haivng the issue , please help me
RewardedVideoAdModule is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener
react-native v0.58.6, react-native-admob v1.3.2

breakerof · 2019-03-02T06:46:47Z

hi guys,

if you install the latest version (v2.0.0-beta5) than the bug is gone.

kinjal111 · 2019-03-02T06:48:09Z

ok thanks let me try then On Saturday, 2 March, 2019, 12:16:49 pm IST, Arton Berisha <notifications@github.com> wrote: hi guys, if you install the latest version (v2.0.0-beta5) than the bug is gone. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

ghost · 2019-03-02T12:27:20Z

I have tried v2.0.0-beta5
on react-native-cli: 2.0.1 / react-native: 0.58.6

But it makes "application has stopped"

breakerof · 2019-03-02T12:34:56Z

@kaiserleka have you looked at the emulator/device logs? maybe the application-id is wrong or missing?

kinjal111 · 2019-03-02T12:39:53Z

@kaiserleka . i was also getting that same issue. but my issue is fixed after i added below statement in
android\app\build.gradle file
dependencies {
......
compile 'com.google.android.gms:play-services-ads:15.0.0'
implementation project(':react-native-admob')
...
}

bosz · 2019-03-06T06:54:34Z

This has been fixed already in #273 . Are you using the latest version of this library?

Thanks man, this saved me hours,

laptran-sym · 2019-05-10T08:42:53Z

This has been fixed already in #273 . Are you using the latest version of this library?

Thanks man, this saved me hours,

That PR resolve this problem but it create new one => stop application

Osamasomy · 2019-07-29T15:22:18Z

I have tried v2.0.0-beta5
on react-native-cli: 2.0.1 / react-native: 0.58.6

But it makes "application has stopped"

implementation ('com.google.android.gms:play-services-ads:16.+') { force = true; }

put in android/app/build.gradle
its work for me i am using react-native 0.16.4

iLevye · 2019-09-06T16:39:28Z

Some versions (don't ask which one) of com.google.android.gms.ads.reward.RewardedVideoAdListener requires onRewardedVideoCompleted function. RNAdMobRewardedVideoAdModule class implements that class.

If you don't want to manage gms versions you can just create an empty function. I can't find any javascript call to that method anyway.

RNAdMobRewardedVideoAdModule.java

    @Override
    public void onRewardedVideoCompleted(){

    }

If your version of react-native-admob has onRewardedVideoCompleted function and you are getting 'method doesnt override' error, then remove the @OverRide annotation from method.

Sanan4li · 2020-01-27T10:20:20Z

@OverRide
public void onRewardedVideoCompleted(){
}

It Worked but Now the App is Crashed...

amnan181 · 2020-01-27T10:37:32Z

Hi @Sanan4li please add this ------=>

<meta-data
            android:name="com.google.android.gms.ads.APPLICATION_ID"
            android:value="ca-app-pub-xxxxxxxxxxxxxxxx~yyyyyyyyyy"/>

into android AndroidManifest.xml
you can find AndroidManifest.xml from your_project_name/android/app/src/main

amnan181 · 2020-01-27T10:38:52Z

For more information you can visit official link https://developers.google.com/admob/android/quick-start

Sanan4li · 2020-01-27T11:44:06Z

Hi @Sanan4li please add this ------=>
<meta-data
            android:name="com.google.android.gms.ads.APPLICATION_ID"
            android:value="ca-app-pub-xxxxxxxxxxxxxxxx~yyyyyyyyyy"/>
into android AndroidManifest.xml
you can find AndroidManifest.xml from your_project_name/android/app/src/main

Thanks... it worked but having another issue... I think it will be fixed... Thanks a lot.

amnan181 · 2020-01-27T11:51:02Z

can you send me AndroidManifest.xml code

Sanan4li · 2020-01-27T11:52:39Z

can you send me AndroidManifest.xml code

I updated the comment.. after reinstalling the app it worked..

amnan181 · 2020-01-27T11:58:35Z

Hi @Sanan4li please add this ------=>
<meta-data
            android:name="com.google.android.gms.ads.APPLICATION_ID"
            android:value="ca-app-pub-xxxxxxxxxxxxxxxx~yyyyyyyyyy"/>
into android AndroidManifest.xml
you can find AndroidManifest.xml from your_project_name/android/app/src/main
Thanks... it worked but having another issue... I think it will be fixed... Thanks a lot.

Great

amnan181 · 2020-01-27T11:59:05Z

Hi @Sanan4li please add this ------=>
<meta-data
            android:name="com.google.android.gms.ads.APPLICATION_ID"
            android:value="ca-app-pub-xxxxxxxxxxxxxxxx~yyyyyyyyyy"/>
into android AndroidManifest.xml
you can find AndroidManifest.xml from your_project_name/android/app/src/main
Thanks... it worked but having another issue... I think it will be fixed... Thanks a lot.

Great

koenpunt closed this as completed May 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RNAdMobRewardedVideoAdModule is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener #316

RNAdMobRewardedVideoAdModule is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener #316

Buwaneka-Sumanasekara commented May 30, 2018 •

edited

ray-shawn commented May 30, 2018

koenpunt commented May 30, 2018

ray-shawn commented May 31, 2018 •

edited

wbrickner commented Dec 18, 2018

raikk commented Dec 28, 2018

zxxza11 commented Dec 29, 2018

Batuhan-Akkaya commented Jan 5, 2019

amnan181 commented Jan 14, 2019

Anandks1993 commented Jan 15, 2019

SimonHudec commented Feb 2, 2019

sonicsmith commented Feb 18, 2019

jdgalani commented Feb 19, 2019

ghost commented Feb 25, 2019

breakerof commented Mar 1, 2019

kinjal111 commented Mar 2, 2019 •

edited

breakerof commented Mar 2, 2019

kinjal111 commented Mar 2, 2019 via email

ghost commented Mar 2, 2019

breakerof commented Mar 2, 2019

kinjal111 commented Mar 2, 2019

bosz commented Mar 6, 2019

laptran-sym commented May 10, 2019

Osamasomy commented Jul 29, 2019

iLevye commented Sep 6, 2019 •

edited

Sanan4li commented Jan 27, 2020

amnan181 commented Jan 27, 2020 •

edited

amnan181 commented Jan 27, 2020

Sanan4li commented Jan 27, 2020 •

edited

amnan181 commented Jan 27, 2020

Sanan4li commented Jan 27, 2020

amnan181 commented Jan 27, 2020

amnan181 commented Jan 27, 2020

RNAdMobRewardedVideoAdModule is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener #316

RNAdMobRewardedVideoAdModule is not abstract and does not override abstract method onRewardedVideoCompleted() in RewardedVideoAdListener #316

Comments

Buwaneka-Sumanasekara commented May 30, 2018 • edited

ray-shawn commented May 30, 2018

koenpunt commented May 30, 2018

ray-shawn commented May 31, 2018 • edited

wbrickner commented Dec 18, 2018

raikk commented Dec 28, 2018

zxxza11 commented Dec 29, 2018

Batuhan-Akkaya commented Jan 5, 2019

amnan181 commented Jan 14, 2019

Anandks1993 commented Jan 15, 2019

SimonHudec commented Feb 2, 2019

sonicsmith commented Feb 18, 2019

jdgalani commented Feb 19, 2019

ghost commented Feb 25, 2019

breakerof commented Mar 1, 2019

kinjal111 commented Mar 2, 2019 • edited

breakerof commented Mar 2, 2019

kinjal111 commented Mar 2, 2019 via email

ghost commented Mar 2, 2019

breakerof commented Mar 2, 2019

kinjal111 commented Mar 2, 2019

bosz commented Mar 6, 2019

laptran-sym commented May 10, 2019

Osamasomy commented Jul 29, 2019

iLevye commented Sep 6, 2019 • edited

Sanan4li commented Jan 27, 2020

amnan181 commented Jan 27, 2020 • edited

amnan181 commented Jan 27, 2020

Sanan4li commented Jan 27, 2020 • edited

amnan181 commented Jan 27, 2020

Sanan4li commented Jan 27, 2020

amnan181 commented Jan 27, 2020

amnan181 commented Jan 27, 2020

Buwaneka-Sumanasekara commented May 30, 2018 •

edited

ray-shawn commented May 31, 2018 •

edited

kinjal111 commented Mar 2, 2019 •

edited

iLevye commented Sep 6, 2019 •

edited

amnan181 commented Jan 27, 2020 •

edited

Sanan4li commented Jan 27, 2020 •

edited