@link("lib") is ignored with top-level @extern methods

[lolgab]

While

@extern
@link("unit")
object externs {
  def nxt_unit_init(init: Ptr[Byte]): Ptr[Byte] = extern
}

does add -lunit to the linking options, the equivalent top-level definition doesn't add linking options:

@extern
@link("unit")
def nxt_unit_init(init: Ptr[Byte]): Ptr[Byte] = extern

[armanbilge]

I think @define will have the same issue, I noticed this when working on it. The reachability analysis currently only considers these annotation/attributes for modules (i.e. objects), not for methods. But it can be fixed :)

scala-native/tools/src/main/scala/scala/scalanative/linker/Reach.scala

Lines 630 to 643 in de31196

	def reachModule(defn: Defn.Module): Unit = {
	val Defn.Module(attrs, name, parent, traits) = defn
	implicit val pos: nir.Position = defn.pos
	newInfo(
	new Class(
	attrs,
	name,
	parent.map(classInfoOrObject),
	traits.flatMap(traitInfo),
	isModule = true
	)
	)
	reachAttrs(attrs)
	}

[WojciechMazur]

Thank you for report and the reproducer. I think we were not checking method annotations in the compiler plugin. The fix is on the way.