Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.5.0-RC2] Better explain multithreading in compilation message #3857

Closed
spamegg1 opened this issue Mar 31, 2024 · 1 comment
Closed

[0.5.0-RC2] Better explain multithreading in compilation message #3857

spamegg1 opened this issue Mar 31, 2024 · 1 comment

Comments

@spamegg1
Copy link
Contributor

Currently it says:

Linking (multithreadingEnabled=true, disable if not used) (2289 ms)

I thought it was asking me to disable it, so I was searching for a nativeConfig option to disable it.

According to this PR it is enabled by default, automatically disables itself if not used.

Not sure what the correct message should be. Something like:

Linking (multithreadingEnabled=true by default, will be disabled automatically if not used) (2289 ms)

or maybe

Linking (multithreadingEnabled=true) (2289 ms)

...

Linking (multithreadingEnabled=false since it was not detected to be used) (2289 ms)

or maybe just don't mention it at all, since it's disabled when unused, enabled when used.

@spamegg1
Copy link
Contributor Author

Currently on 0.5.0 it says:

[info] Multithreading was not explicitly enabled - initial class loading has not detected any usage of system threads. Multithreading support will be disabled to improve performance.

Looks good! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant