Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string.strtok should return CString, not CChar #655

Closed
rwhaling opened this issue Apr 21, 2017 · 1 comment
Closed

string.strtok should return CString, not CChar #655

rwhaling opened this issue Apr 21, 2017 · 1 comment
Milestone

Comments

@rwhaling
Copy link
Contributor

I was having trouble getting string.strtok to work right, and noticed it's return type is CChar -- since the C function returns char *, I think that should be CString, instead?
http://man7.org/linux/man-pages/man3/strtok.3.html

#include <string.h>

       char *strtok(char *str, const char *delim);

I'll quickly submit a one-line patch now with the change, but I'm happy to write a unit test if that's merited.

@densh densh added this to the 0.2 milestone Apr 21, 2017
@densh
Copy link
Member

densh commented Apr 21, 2017

Fixed in #656

@densh densh closed this as completed Apr 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants