Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Margin padding fails for layer bounding boxes #1117

Closed
AndreaNathansen opened this issue Jun 24, 2024 · 1 comment · Fixed by #1120
Closed

Margin padding fails for layer bounding boxes #1117

AndreaNathansen opened this issue Jun 24, 2024 · 1 comment · Fixed by #1120
Assignees
@markbader
Labels
bug

Comments

@AndreaNathansen
Copy link

Context

Expected Behavior

  • The padded bounding box should be returned.

Current Behavior

  • Currently, I get a NotImplementedError because the layer bounding box is an NDBoundingBox for which padded_with_margins has not been implemented yet.

Steps to Reproduce the bug

  1. Load a Dataset, get one of the layers' bounding box.
  2. Try to add padding by calling padded_with_margins on the bounding box.
@fm3
Copy link
Member

fm3 commented Jun 25, 2024

Note that if you know your layer to be 3D only, you can use the adapter wk.BoundingBox.from_ndbbox(layer.bounding_box)

@markbader markbader mentioned this issue Jun 26, 2024
Merged
1 task
@markbader markbader self-assigned this Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markbader markbader

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add implementation for padded_with_margins to nd_bbox. scalableminds/webknossos-libs
3 participants
@fm3 @markbader @AndreaNathansen