Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse compression on sharded neuroglancer datasets #7135

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Reverse compression on sharded neuroglancer datasets #7135

merged 2 commits into from
Jun 13, 2023

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Jun 12, 2023 •
edited

URL of deployed dev instance (used for testing):

  • https://__.webknossos.xyz

Seems like I misunderstood the precomputed specification with the order of decompressions, which caused problems with one dataset's sharded segmentation.

Steps to test:

  • Open sharded datasets, specifically manc-v1 was failing and works now, while the others should still work.

(Please delete unneeded items, merge only when none are left open)

  • Updated changelog
  • Needs datastore update after deployment

@frcroth frcroth requested a review from fm3 June 12, 2023 16:14
@frcroth frcroth marked this pull request as ready for review June 12, 2023 16:14
fm3
fm3 approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frcroth frcroth merged commit 3984378 into master Jun 13, 2023
2 checks passed
@frcroth frcroth deleted the reverse-compression-neuroglancer branch June 13, 2023 07:13
hotzenklotz added a commit that referenced this pull request Jun 14, 2023
@hotzenklotz
Merge branch 'master' of github.com:scalableminds/webknossos into red…
8e3a3e2 
…esign-right-sidebar

* 'master' of github.com:scalableminds/webknossos:
  Layer actions overflow menu (#7123)
  Unify DatasetPath and VaultPath, cleaner ChunkReader creation (#7134)
  Segment to Bucket Index for Volume Annotations (#7063)
  Reverse compression on sharded neuroglancer datasets (#7135)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fm3 fm3 fm3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frcroth @fm3