Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialization options not set up properly #195

Closed
tgodzik opened this issue Feb 18, 2022 · 2 comments
Closed

Initialization options not set up properly #195

tgodzik opened this issue Feb 18, 2022 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@tgodzik
Copy link
Collaborator

tgodzik commented Feb 18, 2022

When we run/debug in Metals the initialization options are set as follows:

[Trace][04:50:00 PM] Received response:
{
  "type": "response",
  "seq": 1,
  "request_seq": 1,
  "command": "initialize",
  "success": true,
  "body": {
    "supportsConfigurationDoneRequest": true,
    "supportsHitConditionalBreakpoints": true,
    "supportsConditionalBreakpoints": true,
    "supportsEvaluateForHovers": true,
    "supportsCompletionsRequest": true,
    "supportsRestartFrame": true,
    "supportsSetVariable": true,
    "supportsRestartRequest": false,
    "supportTerminateDebuggee": true,
    "supportsDelayedStackTraceLoading": false,
    "supportsLogPoints": true,
    "supportsExceptionInfoRequest": true,
    "exceptionBreakpointFilters": [
      {
        "label": "Uncaught Exceptions",
        "filter": "uncaught"
      },
      {
        "label": "Caught Exceptions",
        "filter": "caught"
      }
    ]
  }
}

some of that is not true (supportsConditionalBreakpoints etc.) and most likely is set by the java debug server.

We should handle initialize request ourselves.

@tgodzik tgodzik added the bug Something isn't working label Feb 18, 2022
@adpi2
Copy link
Member

adpi2 commented Feb 18, 2022

Thanks for reporting this!

@adpi2 adpi2 added the good first issue Good for newcomers label Mar 21, 2022
@adpi2
Copy link
Member

adpi2 commented Oct 21, 2022

@adpi2 adpi2 closed this as completed Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants