VS Code extension opting into editor.suggest.insertMode

[nor]

Is your feature request related to a problem? Please describe.

When using "Trigger Suggest" and selecting completion item, the completion item is inserted, without replacing the rest of the word - even though editor.suggest.insertMode is set to replace. E.g.;

Triggering completion from this cursor position foo.eval<cursor>Tap and selecting evalMap - results in foo.evalMapTap

Describe the solution you'd like

The VS Code setting editor.suggest.insertMode has this description:

Controls whether words are overwritten when accepting completions. Note that this depends on extensions opting into this feature.

If possible, it would be nice if the Metals extension could "opt in" to this feature.

[tgodzik]

Thanks for reporting! This should be doable and seems to use the newly added option to 3.16.0:

/**
 *Client supports insert replace edit to control different behavior if
 * a completion item is inserted in the text or should replace text.
 *
 * @since 3.16.0
 */
insertReplaceSupport?: boolean;

at https://microsoft.github.io/language-server-protocol/specification#textDocument_completion

[nor]

No longer an issue. Thanks

[tgodzik]

I think it's worth leaving it open as we still don't support the feature

[nor]

Ok, but it works as expected with the latest versions at least - extension v1.25.0 in VS Code 1.82.0.

[tgodzik]

That's interesting, I will check out what is going on, maybe VS Code does something itself 🤔

[tgodzik]

Looks like in some cases this might work, but still need to be implemented to be reliable