Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindTextInJars - implement search rules to support all fields from TextSearchQuery #261

Open
dos65 opened this issue Oct 27, 2021 · 0 comments

Comments

@dos65
Copy link
Member

dos65 commented Oct 27, 2021

In scalameta/metals#3093 we added a new endpoint - metals/findTextInDependencyJars.

Its request parameters model was copied from VS Code proposed API in order to switch the UI part of this search in VS Code extension to native one after this API become stable.

The issue is that the initial implementation respects only TextSearchQuery.pattern while other fields are ignored.
To complete this feature on server side we need to process isRegExp, isCaseSensitive, isWordMath fields too.

@tgodzik tgodzik transferred this issue from scalameta/metals Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants