Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Member Completions for Scala 3 #292

Open
vzmerr opened this issue Jul 29, 2022 · 8 comments
Open

Adding Member Completions for Scala 3 #292

vzmerr opened this issue Jul 29, 2022 · 8 comments
Assignees

Comments

@vzmerr
Copy link

vzmerr commented Jul 29, 2022

Is your feature request related to a problem? Please describe.

Currently we do not support member completions for Scala 3.
To illustrate, in the following sample code, with @@ representing the cursor position, scala.IndexedSeq[T] is not offered in the completions in Select as a member of package scala

        new scala.IndexedSeq@@
      }

It seems that this is happening because CompletionKind.Members is not covered in enrichWithSymbolSearch. And the challenge is to filter out the non-members.

Describe the solution you'd like

Member completions is offered

Describe alternatives you've considered

not providing the feature

Additional contex

No response

Search terms

scala 3 completions member filter

@vzmerr
Copy link
Author

vzmerr commented Jul 29, 2022

I wanted to self assign but not having permission. Please do not take this. I am working on it now.

@vzmerr
Copy link
Author

vzmerr commented Aug 1, 2022

Update: according to @tgodzik, the completion for this, most probably should be coming from the compiler. So we need to see if the issue is on the compiler side.

@tgodzik
Copy link
Contributor

tgodzik commented Aug 3, 2022

Actually the test fails but it seems to work locally, not sure why. 🤔

@vzmerr
Copy link
Author

vzmerr commented Aug 3, 2022

Actually the test fails but it seems to work locally, not sure why. 🤔

Intellisense maybe?

@tgodzik
Copy link
Contributor

tgodzik commented Aug 3, 2022

Yes, but also Intellisense is provided by Metals

@vzmerr
Copy link
Author

vzmerr commented Aug 3, 2022

Yes, but also Intellisense is provided by Metals

Metals contributes to its results or is Metals providing that?

@tgodzik
Copy link
Contributor

tgodzik commented Aug 3, 2022

It's just Metals providing it aside from the text based ones, which don't have any icons shown next to it.

@vzmerr
Copy link
Author

vzmerr commented Aug 3, 2022

It's just Metals providing it aside from the text based ones, which don't have any icons shown next to it.

perhaps the test results refer to an intermediary step in the process of providing the final completion list then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants