Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise a warning when package doesn't reflect file path #303

Open
kpodsiad opened this issue Sep 15, 2022 · 3 comments
Open

Raise a warning when package doesn't reflect file path #303

kpodsiad opened this issue Sep 15, 2022 · 3 comments

Comments

@kpodsiad
Copy link
Member

kpodsiad commented Sep 15, 2022

Is your feature request related to a problem? Please describe.

It is a good practice that package should correspond to the file path (or the other way around). Metals could show a warning when it doesn't.

Ideally, this warning should be easy to turn off because it might be annoying if one's working in the workspace when package and paths don't match.

Describe the solution you'd like

Screenshot 2022-09-15 at 09 07 54

Describe alternatives you've considered

none

Additional context

No response

Search terms

package warning diagnostics

@tgodzik
Copy link
Contributor

tgodzik commented Sep 15, 2022

It would be really nice to include that as a Scalafix linting rule 🤔

Should be fairly simple to do that and can be configured by users themselves in the config file. Otherwise we risk the settings growing too much

@kpodsiad
Copy link
Member Author

It would be really nice to include that as a Scalafix linting rule 🤔

Embedded in Metals or a standalone one?

@tgodzik
Copy link
Contributor

tgodzik commented Sep 15, 2022

It would be really nice to include that as a Scalafix linting rule thinking

Embedded in Metals or a standalone one?

I would say embedded in Metals since it would otherwise need a BSP integration for each server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants