Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command metals-model-refresh should only be sent to clients with debugging support #1016

Closed
olafurpg opened this issue Oct 24, 2019 · 0 comments · Fixed by #1019
Closed

Command metals-model-refresh should only be sent to clients with debugging support #1016

olafurpg opened this issue Oct 24, 2019 · 0 comments · Fixed by #1019
Assignees
@mzarnowski
Labels
bug Something that is making a piece of functionality unusable
Milestone
Metals v0.8 - Cobalt

Comments

@olafurpg
Copy link
Member

Describe the bug

When using the latest SNAPSHOT of Metals with Emacs we get the following warning

Warning (lsp-mode): Unknown metals client command: metals-model-refresh

The warning origins from

metals/metals/src/main/scala/scala/meta/internal/metals/MetalsLanguageServer.scala

Line 1536 in 68459a7

.foreach(_ => languageClient.refreshModel())

Expected behavior

No warning because the Emacs client doesn't support debugging.

Additional context

https://gitter.im/scalameta/metals?at=5db154c72f8a034357c9cd58
@mzarnowski mzarnowski mentioned this issue Oct 25, 2019
Merged
@tgodzik tgodzik added the bug Something that is making a piece of functionality unusable label Oct 26, 2019
@tgodzik tgodzik added this to the Metals v0.8 - Cobalt milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mzarnowski mzarnowski

Labels
bug Something that is making a piece of functionality unusable
Projects
None yet
Milestone
Metals v0.8 - Cobalt
Development

Successfully merging a pull request may close this issue.

Suppress model-refresh if debugging is unsupported
3 participants
@olafurpg @mzarnowski @tgodzik