Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non atomic updates on TrieMap in SymbolIndexBucket #5072

Closed
kpodsiad opened this issue Mar 21, 2023 · 0 comments
Closed

Non atomic updates on TrieMap in SymbolIndexBucket #5072

kpodsiad opened this issue Mar 21, 2023 · 0 comments
Assignees
@jkciesluk
Labels
tech debt We should have addressed this yesterday
Milestone
Metals v1.2.1

Comments

@kpodsiad
Copy link
Member

Originated in #5042 (comment).

There are some operations on TrieMap in SymbolIndexBucket which are not atomic. There's tiny chance that this can lead to bug, nevertheless it is good to avoid such situations if possible. It seems like because mtags are being cross published between many scala versions, we cannot use TrieMap's updateWith function. Maybe using some wrapper over java's ConcurrentHashMap (to not deal with null) will do the job?
@kpodsiad kpodsiad mentioned this issue Mar 21, 2023
Merged
@tgodzik tgodzik added the tech debt We should have addressed this yesterday label Mar 27, 2023
@jkciesluk jkciesluk self-assigned this Dec 11, 2023
@jkciesluk jkciesluk mentioned this issue Dec 13, 2023
Merged
@tgodzik tgodzik closed this as completed Jan 5, 2024
@kasiaMarek kasiaMarek added this to the Metals v1.2.1 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jkciesluk jkciesluk

Labels
tech debt We should have addressed this yesterday
Projects
None yet
Milestone
Metals v1.2.1
Development

No branches or pull requests
4 participants
@tgodzik @kasiaMarek @kpodsiad @jkciesluk