Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hover shows wrong information #601

Closed
laughedelic opened this issue Mar 31, 2019 · 3 comments · Fixed by #602
Closed

Hover shows wrong information #601

laughedelic opened this issue Mar 31, 2019 · 3 comments · Fixed by #602
Labels
bug Something that is making a piece of functionality unusable
Milestone
Metals v0.5 - Mer...

Comments

@laughedelic
Copy link
Member

laughedelic commented Mar 31, 2019 •
edited

Describe the bug

I noticed that hover sometimes shows a tooltip that looks different (broken formatting) and for the wrong symbol.

To Reproduce

I tried it out on the atom-ide-scala code:

https://github.com/laughedelic/atom-ide-scala/blob/8684c979ebd6561e43bffd31349d76eb2f24018f/src/main/scala/ScalaLanguageClient.scala#L64

Expected behavior

Tooltip with information for the symbol/expression under the cursor.

Screenshots

Screenshot 2019-03-30 at 02 21 33

Screenshot 2019-03-31 at 01 29 24

Notice that both of these symbols appear inside of the NotificationOptions constructor.

Installation:

  • Operating system: macOS
  • Editor: Atom
  • Metals version: v0.4.4-209-gf6986d46 (latest master at the moment of writing)
@laughedelic
Copy link
Member Author

Reproducible in VS Code as well:

Screenshot 2019-03-31 at 01 38 49

@laughedelic laughedelic added the bug Something that is making a piece of functionality unusable label Mar 31, 2019
@olafurpg
Copy link
Member

Thanks for reporting! This is due to buggy handling of named arguments

@olafurpg olafurpg added this to the Metals v0.5 - Mercury milestone Apr 1, 2019
@olafurpg olafurpg mentioned this issue Apr 1, 2019
Merged
@olafurpg
Copy link
Member

olafurpg commented Apr 1, 2019

Pending "fix" in #602. It's not a great fix because now hover shows the full method signature instead of only the parameter signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something that is making a piece of functionality unusable
Projects
None yet
Milestone
Metals v0.5 - Mercury
Development

Successfully merging a pull request may close this issue.

Remove signature help fallback in hover. olafurpg/metals
2 participants
@laughedelic @olafurpg