You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That when the task start happens it finds the compilation and calls trackFuture. It's in here that the actual check for "off" is and the progess is created and both the create and notify is done one right after the other:
The progress gets updated, but this will never actual be forwarded to the LSP client since there is no mechanism to check the queue and send them. There is a tick mechanism that at times updates the metals status, but doesn't send progress notifications.
Expected behavior
I'd expect that upon receiving a build/taskProgress with a compilation % that it would be forwarded to the LSP client.
Operating system
macOS
Editor/Extension
Nvim (nvim-metals)
Version of Metals
1.2.2+55-9855505a-SNAPSHOT
Extra context or search terms
No response
The text was updated successfully, but these errors were encountered:
tgodzik
added
the
bug
Something that is making a piece of functionality unusable
label
Mar 1, 2024
Describe the bug
When turning off the status bar an LSP client isn't forwarded the actual progress updates from the build server. You can see here:
metals/metals/src/main/scala/scala/meta/internal/metals/ForwardingMetalsBuildClient.scala
Lines 177 to 182 in 9855505
That when the task start happens it finds the compilation and calls
trackFuture
. It's in here that the actual check for "off" is and the progess is created and both thecreate
andnotify
is done one right after the other:metals/metals/src/main/scala/scala/meta/internal/metals/StatusBar.scala
Lines 119 to 145 in 9855505
Notice that the
end
is sent once the promise is completed. If you then look at what happens when abuild/taskProgress
comes in:metals/metals/src/main/scala/scala/meta/internal/metals/ForwardingMetalsBuildClient.scala
Line 276 in 9855505
The
progress
gets updated, but this will never actual be forwarded to the LSP client since there is no mechanism to check the queue and send them. There is a tick mechanism that at times updates the metals status, but doesn't send progress notifications.Expected behavior
I'd expect that upon receiving a
build/taskProgress
with a compilation % that it would be forwarded to the LSP client.Operating system
macOS
Editor/Extension
Nvim (nvim-metals)
Version of Metals
1.2.2+55-9855505a-SNAPSHOT
Extra context or search terms
No response
The text was updated successfully, but these errors were encountered: