Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not seeing auto import in quick fix prompt since v1.32.0. #6419

Open
megri opened this issue May 17, 2024 · 1 comment
Open

Not seeing auto import in quick fix prompt since v1.32.0. #6419

megri opened this issue May 17, 2024 · 1 comment
Labels
BSP Generic BSP related tickets bug Something that is making a piece of functionality unusable mill Mill related tickets upstream-fix-needed Waiting on a fix upstream

Comments

@megri
Copy link

megri commented May 17, 2024

Note: To me this only happens in mill-bsp mode; Bloop seems to work as expected.

Activating auto complete or clicking the lightbulb for a quick fix in versions v1.31.0 and below will offer to add an import statement for a class if it's in the index and currently not imported.

From v.1.32.0+ this prompt will not display auto import.

To Reproduce Steps to reproduce the behavior:

I can reproduce this with the following setup

  • Mill, version 0.11.7 (in .mill-version file)
  • def scalaVersion = "3.4.1"
  • Run the Metals: Attempt to generate bsp config for build tool. action — this puts vscode-metals into mill-bsp mode.

After this step a very simple program can be constructed:

@main def App() =
    val x = ListBuffer

Attempting to quick-fix the ListBuffer symbol will trigger the behaviour.

Screenshots
image

image

Installation:

  • Operating system: macOS
  • VSCode version: 1.89.1
  • VSCode extension version: 1.32.0+
  • Metals version: default/not changed by me, but seems to be set to 1.3.0 rather than 1.3.1 🤔

Additional context

Search terms

mill bsp quick fix auto import

@tgodzik
Copy link
Contributor

tgodzik commented May 17, 2024

Looks like a change in Metals exposed an issue in Mill BSP. We can easily work around it, but in the long run I think it would be worth solving com-lihaoyi/mill#3165

@tgodzik tgodzik added bug Something that is making a piece of functionality unusable mill Mill related tickets upstream-fix-needed Waiting on a fix upstream BSP Generic BSP related tickets labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BSP Generic BSP related tickets bug Something that is making a piece of functionality unusable mill Mill related tickets upstream-fix-needed Waiting on a fix upstream
Projects
None yet
Development

No branches or pull requests

2 participants