Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grpc service name visible in generated code #108

Closed
eiennohito opened this issue May 4, 2016 · 1 comment
Closed

Make grpc service name visible in generated code #108

eiennohito opened this issue May 4, 2016 · 1 comment

Comments

@eiennohito
Copy link
Contributor

eiennohito commented May 4, 2016

Right now it is inlined, but exposing it will make it easier for more advanced code.

For example, I am trying to use grpc with akka streams for backpressure support.

I can submit a pull request containing base trait for services and patch for generator.

trait GrpcService { def name: String }

@thesamet
Copy link
Contributor

thesamet commented May 8, 2016

Fixed by a754b35.

The service name can be exposed through Service.descriptor.getName()

@thesamet thesamet closed this as completed May 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants