Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any plan to support GRPC? #44

Closed
xuwei-k opened this issue Oct 20, 2015 · 14 comments
Closed

Is there any plan to support GRPC? #44

xuwei-k opened this issue Oct 20, 2015 · 14 comments

Comments

@xuwei-k
Copy link
Contributor

xuwei-k commented Oct 20, 2015

http://www.grpc.io/

@zackangelo
Copy link
Contributor

👍

I've modified the Java GRPC compiler to create Scala service stubs instead. I'd be interested in porting that work over if it's something others are interested in.

We'd also need proto3 support. I think we're close, there doesn't seem to be a big difference between the two. The biggest change needed I've found is for all fields to be optional.

@He-Pin
Copy link

He-Pin commented Oct 29, 2015

@zackangelo
currently the grpc don't support scala directly,seems like we could leverage work here just as what you said.
it's beta now,I think will be soon to the GA stage.

@tayama0324
Copy link

I am woking on scala gRPC support with @xuwei-k. We will fork ScalaPB rather than sending pull requests to get things done quickly. Let us know if you have any concerns. This issue will be closed in a few days.

@thesamet
Copy link
Contributor

@tayama0324 nice, would definitely love to have it merged here when you're ready.

@iphydf
Copy link

iphydf commented Nov 16, 2015

About making all fields optional: can this be a setting, so I can choose to make all fields non-optional, instead? Wrapping everything in an Option can become too much overhead. The proto3 semantics allow for this (see this example).

@thesamet
Copy link
Contributor

@iphydf the above comment seem to be unrelated to this bug - can you please file a different issue? FWIW, in Scalapb >= 0.5, primitives are not wrapped in an Option for proto3.

@agnek
Copy link

agnek commented Nov 16, 2015

@xuwei-k @tayama0324 can I help you and contribute some code? I want to use grpc at work.

@thesamet
Copy link
Contributor

thesamet commented Dec 2, 2015

Status update: merge @xuwei-k PR into the grpc branch here. Added an implementation of a Marshaller to avoid conversions to/from Java protobufs.

@xuwei-k
Copy link
Contributor Author

xuwei-k commented Dec 3, 2015

Added an implementation of a Marshaller to avoid conversions to/from Java protobufs.

Excellent! thanks a lot 😄

@thesamet
Copy link
Contributor

thesamet commented Dec 7, 2015

The work has been merged into master and released in 0.5.18. Thanks @xuwei-k for doing the heavy lifting!

@xuwei-k
Copy link
Contributor Author

xuwei-k commented Dec 19, 2015

FYI, I and @tayama0324 translated grpc-java examples. https://github.com/xuwei-k/grpc-scala-sample

@thesamet
Copy link
Contributor

This is really awesome - thank you! When I get to write the docs for
ScalaPB/grpc I'll make sure to link to this repo.

On Fri, Dec 18, 2015 at 8:04 PM, kenji yoshida notifications@github.com
wrote:

FYI, I and @tayama0324 https://github.com/tayama0324 translated
grpc-java examples. https://github.com/xuwei-k/grpc-scala-sample


Reply to this email directly or view it on GitHub
#44 (comment).

-Nadav

@abhinavzspace
Copy link

This is great. Can you show us (java guys) a few hints on where to look for the code for implementing grpc on our projects @xuwei-k and @tayama0324 in https://github.com/xuwei-k/grpc-scala-sample. Thanks a lot for this excellent work.

@mkotsbak
Copy link

mkotsbak commented Apr 1, 2017

Documentation: https://scalapb.github.io/grpc.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants