Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalar DB Schema Tool fails due to parser tool updates. #19

Closed
KenYurino opened this issue Dec 13, 2018 · 3 comments
Closed

Scalar DB Schema Tool fails due to parser tool updates. #19

KenYurino opened this issue Dec 13, 2018 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@KenYurino
Copy link
Contributor

Scalar DB Schema Tools can not be "make".

The reason is that the IF of the Parser being used by the Tool has changed, and since there is an argument with no argument, an error occurs at make time.

■Error detail

$ cd tools/schema
$ make
go get github.com/alecthomas/kingpin
go get github.com/alecthomas/participle

  1. _/home/ec2-user/scalardb/tools/schema/internal/parser
    internal/parser/parser.go:42:68: not enough arguments in call to participle.UseLookahead
    have ()
    want (int)
    make: *** エラー 2

■Parser Tool
https://github.com/alecthomas/participle

@scalarindetail
Copy link
Contributor

scalarindetail commented Dec 13, 2018

The problem was caused because the parser library released an update that contained breaking changes (the coded was working with 1.0 but the 2.0 was released 20 days ago).

Libraries are imported with go-get but it does not allow to specify a version or a branch tag.

install:
	go get github.com/alecthomas/kingpin
	go get github.com/alecthomas/participle

To import the dependencies with fixed version, we could use a tool such as dep.
The make would become:

install:
        go get -u github.com/golang/dep/cmd/dep
        dep ensure (will download the library for the project)

@feeblefakie feeblefakie added the bug Something isn't working label Dec 14, 2018
@feeblefakie
Copy link
Contributor

feeblefakie commented Dec 14, 2018

@yuriken27 I think this is now fixed with 74dba96 .
Can you check ?

@feeblefakie feeblefakie changed the title Scalar DB Schema Tool make error because of IF of the parser tool changed. Scalar DB Schema Tool fails due to parser tool updates. Dec 14, 2018
@KenYurino
Copy link
Contributor Author

I checked again and this problem was corrected.
Schema Tool works correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants